-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Temporarily remove getPullRequestsMergedBetween unit test #7119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving and merging to unblock contributor PRs.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @Julesssss in version: 1.1.27-2 🚀
|
🚀 Deployed to staging by @Julesssss in version: 1.1.27-3 🚀
|
🚀 Deployed to staging by @Julesssss in version: 1.1.27-3 🚀
|
Details
Contributor PRs are failing unit tests because they do not have access to the repo secrets necessary for
OSBotify
to configure commit signing on the GitHub Actions runner. This PR should fix that temporarily removing the new failing test, pending a solution that doesn't require commit signing (or doesn't use actual GPG keys).Fixed Issues
$ https://github.com/Expensify/Expensify/issues/191675
Tests
None - only PR checks.
QA Steps
No QA.
Tested On